Initial changes for the handoff from Embark to the community. #1
Conversation
|
Note that the docs/pages links won't work until this repo is made public. |
|
@eddyb not sure if you see GitHub review request emails |
Review requests trigger GH Mobile notifs so I do get them, I only put this off because I was looking into one specific SPIR-T bug fix but that's taking longer anyway so I should give this a once-over at least. |
| # Embark Contributor Guidelines | ||
| # Contributor Guidelines |
There was a problem hiding this comment.
Same here as for the code of conduct (as in it looks reasonable but no idea what the delta is to other projects).
| - [Cargo](https://github.com/rust-lang/cargo/) and [crates.io](https://crates.io) support to develop and publish SPIR-V crates | ||
| - High-level render graph to take advantage of this, make it easy for users to develop and use rendering effects. | ||
|
|
||
| ## Process | ||
|
|
||
| We use this repo as a monorepo for everything related to the project: crates, tools, shaders, examples, tests, and design documents. This way, we can use issues and PRs covering everything in the same place, cross-reference stuff within the repo, as well as with other GitHub repos such as [rspirv](https://github.com/gfx-rs/rspirv) and [Rust](https://github.com/rust-lang/rust) itself. |
There was a problem hiding this comment.
Oh this should've been updated when SPIR-T was added, heh.
$ rg -oi '(\S+|.* )embark(\S+| .*)' | rg -v '\.io/cargo-deny|(rust-ecosystem|rust-
gpu|spirt)/(pull|issues)/|Embark standard lints v0\.4'
Cargo.toml:"Embark <[email protected]>"]
LICENSE-MIT:Copyright (c) 2019-2024 Embark Studios
README.md:[Embark](https://www.embark-studios.com/).
README.md:- 2024 Embark transitions maintenance of `rust-gpu` to the open source community.
docs/src/building-rust-gpu.md:https://github.com/EmbarkStudios/rust-gpu
docs/src/building-rust-gpu.md:[SPIRV-Tools](https://github.com/EmbarkStudios/SPIRV-Tools).
docs/src/building-rust-gpu.md:https://github.com/EmbarkStudios/rust-gpu/tree/main/examples
docs/src/building-rust-gpu.md:https://github.com/EmbarkStudios/rust-gpu/tree/main/examples/runners
docs/src/building-rust-gpu.md:https://github.com/EmbarkStudios/rust-gpu/tree/main/examples/runners/ash
docs/src/building-rust-gpu.md:https://github.com/EmbarkStudios/rust-gpu/tree/main/examples/runners/cpu
docs/src/building-rust-gpu.md:https://github.com/EmbarkStudios/rust-gpu/tree/main/examples/runners/wgpu
docs/src/building-rust-gpu.md:https://github.com/EmbarkStudios/rust-gpu/tree/main/examples/shaders
crates/rustc_codegen_spirv/src/lib.rs: clippy::match_on_vec_items, // rustc_codegen_spirv has less strict panic requirements than other embark projects
crates/spirv-std/README.md:https://github.com/EmbarkStudios/rust-gpu/blob/097ba40bedd74eeaa296e719ef7e41f2d3d76c23/docs/src/migration-to-register-tool.md
crates/spirv-std/README.md:https://github.com/EmbarkStudios/rust-gpu/blob/69cb69d28f1e64420ee31ade5e7dffb7c5621e89/examples/shaders/sky-shader/src/lib.rsDid a quick pass, seems like there's a few more links that can be fixed maybe? Also this reminds me we should review Embark's set of clippy lints and figure out what's useful/overly-opinionated, and also what lints we're missing (Embark itself has updated its set of lints several times since the copies in Rust-GPU, too). |
|
Oops, wrong button, sorry! |
Similar to the Rust project. See the git history of https://github.com/rust-lang/rust/blob/master/LICENSE-MIT
| * @eddyb | ||
|
|
||
| /examples/ @fu5ha @VZout | ||
| * @eddyb @LegNeato @fornwall |
There was a problem hiding this comment.
Note I added him to the repo but this will show an error in the UI until he accepts.
| @@ -1,5 +1,3 @@ | |||
| Copyright (c) 2019 Embark Studios | |||
|
|
|||
There was a problem hiding this comment.
Note we are removing copyright entirely, similar to the rust project's MIT license file.
|
@eddyb We good here? I want to get this moving so we can announce this week. |
|
Is there a Matrix or Discord for this or anything else? :P |
No description provided.