Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the latest implementation for String#blank? from ActiveSupport and update benchmark result #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ken3ypa
Copy link

@ken3ypa ken3ypa commented Aug 12, 2023

Diffs

  • Adopted the latest implementation for String#blank? from ActiveSupport. (ref)
  • Update the benchmark to reflect the latest implementation.

I noticed a minor diffs between the latest code in ActiveSupport and benchmarking code in this gem.
After updating, the performance difference appears to be smaller; still this gem remains faster.

Thanks for making this gem. I really like this gem.

@mjankowski
Copy link

I noticed same thing and was going to do similar PR.

I see about a ~1x to ~3x diff locally in benchmark. Still noticeable, but smaller than the ~10+ year old versions of ruby/rails this first worked on.

Also noticed the ruby versions listed in the README are pretty out of date ... might be worth a once over on the ruby/rails versions supported to assist anyone arriving here with an "is this still relevant, given perf improvements in ruby/rails?" sort of question.

@n-rodriguez
Copy link

Hi there! Is this still relevant, given perf improvements in ruby/rails? 😝 (I'm running Rails 7.2 and Ruby 3.3.4)

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants