Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the syntax error for dynamically generating the HTML Tag, #3623

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nomandhoni-cs
Copy link

@nomandhoni-cs nomandhoni-cs commented Sep 24, 2024

PR Summary:

The tag name is being dynamically generated based on a Liquid condition, which isn't valid HTML syntax.
To fix this, I separated the Liquid logic from the HTML tag declaration.

Issue

image

Why are these changes introduced?

Fixes #0.

What approach did you take?

Other considerations

Decision log

# Decision Alternatives Rationale Downsides
1

Visual impact on existing themes

Testing steps/scenarios

  • Step 1

Demo links

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant