Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX-1508] Update documentation for master #5066

Closed
wants to merge 1 commit into from

Conversation

buger
Copy link
Member

@buger buger commented Jul 11, 2024

User description

Triggered by: sredxny

Included:

Tyk Gateway: false
Tyk Dashboard: false
Tyk MDCB true
Tyk Pump false

Intended for: master
Changes sourced from: release-2.6
Config info generator branch: main

Note: (branch suffix: docs)

JIRA: https://tyktech.atlassian.net/browse/DX-1508


PR Type

Documentation


Description

  • Corrected a typo in the MDCB configuration documentation from "behavior" to "behaviour".

Changes walkthrough 📝

Relevant files
Documentation
mdcb-config.md
Corrected typo in MDCB configuration documentation             

tyk-docs/content/shared/mdcb-config.md

  • Corrected a typo in the word "behavior" to "behaviour".
+1/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Copy link
Contributor

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

Copy link
Contributor

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Possible issue
Correct a spelling mistake in an environment variable name

Correct the spelling error in the word "separate" in the environment variable name
to maintain consistency and avoid potential confusion or errors in configuration.

tyk-docs/content/shared/mdcb-config.md [484]

-ENV: <b>TYK_MDCB_ENABLESEPERATEANALYTICSSTORE</b><br />
+ENV: <b>TYK_MDCB_ENABLESEPARATEANALYTICSSTORE</b><br />
 
Suggestion importance[1-10]: 9

Why: The suggestion correctly identifies a spelling mistake in the environment variable name, which is important for maintaining consistency and avoiding potential configuration errors. However, it does not address any functional code changes.

9

Copy link

netlify bot commented Jul 11, 2024

PS. Pls add /docs/nightly to the end of url

Name Link
🔨 Latest commit faa0177
🔍 Latest deploy log https://app.netlify.com/sites/tyk-docs/deploys/6690466e0512110008164f05
😎 Deploy Preview https://deploy-preview-5066--tyk-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

1 similar comment
Copy link

netlify bot commented Jul 11, 2024

PS. Pls add /docs/nightly to the end of url

Name Link
🔨 Latest commit faa0177
🔍 Latest deploy log https://app.netlify.com/sites/tyk-docs/deploys/6690466e0512110008164f05
😎 Deploy Preview https://deploy-preview-5066--tyk-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@letzya
Copy link
Collaborator

letzya commented Jul 12, 2024

not needed. We need to update the source (i.e. mdcb repo) with the US notation

@letzya letzya closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation mdcb 2.6.0 MDCB Version 2.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants