-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-1570/TT-12607]document validating client certificates against rootCA #5069
[TT-1570/TT-12607]document validating client certificates against rootCA #5069
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
7fddf4d
to
24cce41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some observations/questions
tyk-docs/content/basic-config-and-security/security/mutual-tls/client-mtls.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/security/mutual-tls/client-mtls.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/security/mutual-tls/client-mtls.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/security/mutual-tls/client-mtls.md
Outdated
Show resolved
Hide resolved
a006fbc
to
f8ed260
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks.
tyk-docs/content/basic-config-and-security/security/mutual-tls/client-mtls.md
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/security/mutual-tls/client-mtls.md
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/security/mutual-tls/client-mtls.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/security/mutual-tls/client-mtls.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeffy-mathew Will approve ready for release after review comments relating to risks of root CA addressed.
Could you confirm if this PR is targeting release 5.5.0?
bfcf10d
to
b762796
Compare
/release to release-5.4 |
Working on it! Note that it can take a few minutes. |
…tCA (#5069) * document validating client certificates against rootCA * address review comments * Update tyk-docs/content/basic-config-and-security/security/mutual-tls/client-mtls.md * Update tyk-docs/content/basic-config-and-security/security/mutual-tls/client-mtls.md --------- Co-authored-by: Yaara <[email protected]> (cherry picked from commit 48d4c54)
@letzya Succesfully merged PR |
…certificates against rootCA (#5069) [TT-1570/TT-12607]document validating client certificates against rootCA (#5069) * document validating client certificates against rootCA * address review comments * Update tyk-docs/content/basic-config-and-security/security/mutual-tls/client-mtls.md * Update tyk-docs/content/basic-config-and-security/security/mutual-tls/client-mtls.md --------- Co-authored-by: Yaara <[email protected]>
For the record - this feature is arriving in 5.5.0. Don't think it's the end of the world to have merged to release-5.4 docs. |
User description
For internal users - Please add a Jira DX PR ticket to the subject!
https://tyktech.atlassian.net/browse/TT-12607 ---
Preview Link
https://deploy-preview-5069--tyk-docs.netlify.app/docs/nightly/basic-config-and-security/security/mutual-tls/client-mtls/
Description
Screenshots (if appropriate)
Checklist
master
.PR Type
Documentation
Description
Changes walkthrough 📝
client-mtls.md
Document use of root CA certificates for static mTLS authentication
tyk-docs/content/basic-config-and-security/security/mutual-tls/client-mtls.md
(CA) certificates for static mTLS authentication.