You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add warnings about the impacts of filter misconfiguration
Since the filters are crucial for data management, adding a warning or note about the potential impact of misconfiguration could prevent user errors. This could include data loss or performance issues.
-Filters pump data by a block list of api_ids.+Filters pump data by a block list of api_ids. Note: Incorrect configuration of this filter can lead to unintended data exclusion, impacting analytics and reporting.
Suggestion importance[1-10]: 9
Why: Adding warnings about the potential impacts of misconfiguration is crucial for preventing user errors that could lead to data loss or performance issues, making this a valuable addition to the documentation.
9
Enhancement
Add examples and explanations to filter descriptions to enhance clarity
Consider adding a brief explanation or example for each filter type to enhance clarity and provide context on how the filters should be used or configured. This can help users understand the practical application and limitations of each filter.
-Filters pump data by an allow list of org_ids.+Filters pump data by an allow list of org_ids. For example, specify `["org1", "org2"]` to only include data from these organizations.
Suggestion importance[1-10]: 8
Why: Providing examples and explanations can significantly improve the clarity and usability of the documentation, helping users understand how to configure the filters correctly.
8
Maintainability
Ensure consistent terminology in filter descriptions
To maintain consistency and avoid confusion, consider using the same terminology across all filter descriptions. The term "allow list" and "block list" are used, but ensure these are consistently used across all documentation.
-Filters pump data by a block list of org_ids.+Filters pump data by a block list of org_ids. Ensure to use "block list" consistently in all filter descriptions where applicable.
Suggestion importance[1-10]: 7
Why: Consistent terminology is important for maintainability and to avoid confusion among users. This suggestion helps ensure that the documentation is clear and professional.
7
Usability
Suggest adding a table of contents for better navigation
To improve the accessibility and usability of the documentation, consider adding a table of contents at the beginning of the document that links to each filter section. This would help users quickly navigate to the relevant sections.
-Filters pump data by an allow list of response_codes.+Filters pump data by an allow list of response_codes. Consider adding a table of contents at the beginning of the document for easier navigation.
Suggestion importance[1-10]: 6
Why: While adding a table of contents can improve usability and navigation, it is a minor enhancement compared to other suggestions. It is helpful but not critical.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
DX-1509 Update documentation for master (#5067)
Import config/docs
Co-authored-by: sredxny [email protected]
PR Type
Documentation
Description
Changes walkthrough 📝
pump-config.md
Update terminology and correct spelling in pump configuration
documentation.
tyk-docs/content/shared/pump-config.md