You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the title and description of the portal-documentation.md file to clarify API publishing endpoints and added a note on the use of British and American English spellings.
Changed the code block languages for sample requests and responses in portal-documentation.md and portal-keys.md to appropriate formats like http, json, and yaml.
Updated the title and description of the tyk-portal-api.md file to better describe the Classic Portal API.
Revised menu titles and paths in menu.yaml for improved clarity and navigation.
Changes walkthrough 📝
Relevant files
Documentation
portal-documentation.md
Clarify API publishing endpoints and spelling conventions
* Add explanation to the use of catalogue and catalog
* Update tyk-docs/content/tyk-apis/tyk-portal-api/portal-documentation.md
* Update tyk-docs/content/tyk-portal-api.md
* Update portal-documentation.md
(cherry picked from commit cf48485)
Spelling Consistency The note on spelling consistency is helpful, but it might be clearer to provide specific examples of where British and American English differ in the context of the API or UI, rather than a general statement.
Code Block Language The change from generic code blocks to specific languages (http, json, yaml) is good for readability and syntax highlighting. However, ensure that all code blocks in the document follow this new standard for consistency.
Correct the formatting of the HTTP headers in the documentation examples
Ensure that the API endpoint examples in the documentation are correctly formatted to enhance readability and standard compliance. Specifically, the authorization header should be properly formatted with a space after the colon.
Why: Correctly formatting the HTTP headers improves readability and ensures standard compliance, which is important for users following the documentation.
9
Use Markdown syntax for notes to maintain consistency and readability
Replace the direct HTML note block with a Markdown equivalent using blockquotes or a custom Markdown extension if supported, to keep the document format consistent and clean.
-{{< note success >}}-{{< /note >}}+> **Important Note on Spelling:**+> +> While our documentation now uses American English, the product itself, including UI, configuration fields, environment variables, and APIs endpoints, retain British English spellings. When interacting with the product, please continue using the British English spellings as they appear in the interface and API. (This means that for existing users nothing has changed).
Suggestion importance[1-10]: 8
Why: Using Markdown syntax for notes enhances consistency and readability, making the document easier to maintain and understand. This is a good practice for documentation.
8
Consistency
Standardize the use of code block annotations for consistency
It's recommended to use consistent code block annotations for all HTTP and JSON examples. The PR introduces different formats (http and json), which should be standardized across the documentation.
Why: Consistent use of code block annotations enhances the readability and professionalism of the documentation. This is important for maintaining a high standard of documentation quality.
8
Maintainability
Remove unnecessary HTML line break tags from Markdown content
Consider removing the unnecessary tags used for spacing in Markdown files. Markdown provides other ways to manage spacing and layout that are more semantically appropriate, such as using additional newlines or manipulating with CSS in HTML contexts.
Why: Removing unnecessary HTML tags improves the maintainability and readability of the Markdown file. However, this is a minor improvement and does not address any critical issues.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
DX-1520 Add explanation to the use of catalogue and catalog (#5084)
Add explanation to the use of catalogue and catalog
Update tyk-docs/content/tyk-apis/tyk-portal-api/portal-documentation.md
Update tyk-docs/content/tyk-portal-api.md
Update portal-documentation.md
PR Type
Documentation, Enhancement
Description
portal-documentation.md
file to clarify API publishing endpoints and added a note on the use of British and American English spellings.portal-documentation.md
andportal-keys.md
to appropriate formats likehttp
,json
, andyaml
.tyk-portal-api.md
file to better describe the Classic Portal API.menu.yaml
for improved clarity and navigation.Changes walkthrough 📝
portal-documentation.md
Clarify API publishing endpoints and spelling conventions
tyk-docs/content/tyk-apis/tyk-portal-api/portal-documentation.md
portal-keys.md
Update code block languages for portal keys
tyk-docs/content/tyk-apis/tyk-portal-api/portal-keys.md
tyk-portal-api.md
Update Classic Portal API title and description
tyk-docs/content/tyk-portal-api.md
menu.yaml
Revise menu titles and paths for clarity
tyk-docs/data/menu.yaml