Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettierx #322

Draft
wants to merge 3 commits into
base: v2-mst-aptd-at-lcz-sty
Choose a base branch
from
Draft

Add prettierx #322

wants to merge 3 commits into from

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented May 11, 2021

eslint src/ --ext .ts --ext .tsx

/Users/vadorequest/dev/NRN/v2-mst-aptd-at-lcz-sty/src/stories/nrn/text/EllipsisText.stories.tsx
1:1 error Run autofix to sort these imports! simple-import-sort/imports
3:9 warning Replace ´⏎··Meta,⏎··Story,⏎´ with ´·Meta,·Story·´ prettierx/options
13:17 error Unexpected separator (;) @typescript-eslint/member-delimiter-style
16:16 error Always prefer const x: T = { ... } @typescript-eslint/consistent-type-assertions
22:48 warning Replace ´(props)´ with ´props´ prettierx/options
25:10 warning Replace ´(⏎····<EllipsisText⏎······{...props}⏎····>⏎······{text·||·'Default·text'}⏎····⏎⏎··)´ with ´<EllipsisText·{...props}>{text·||·'Default·text'}´ prettierx/options

✖ 3782 problems (1087 errors, 2695 warnings)
761 errors and 2594 warnings potentially fixable with the --fix option.

It's really slow, even when running on a single file (take 5+sec, up to 30sec+ on the whole project). Lots of rules to change, and not sure it'll allow listing all imports/obj properties line by line. We'll probably meet the same limitations we met in #76.


Overall, better than GTS #320, but still based on prettier with no way to override the stuff that matters to me (DX, PR review, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant