added jevois module generation for python #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrossbach
force-pushed
the
jevoisCodeGeneration
branch
4 times, most recently
from
c484663
to
d6eec30
Compare
Codecov Report
@@ Coverage Diff @@
## master #872 +/- ##
============================================
- Coverage 51.71% 51.52% -0.19%
Complexity 1158 1158
============================================
Files 247 247
Lines 7812 7850 +38
Branches 533 539 +6
============================================
+ Hits 4040 4045 +5
- Misses 3591 3622 +31
- Partials 181 183 +2 |
rrossbach
force-pushed
the
jevoisCodeGeneration
branch
from
d6eec30
to
f6fad18
Compare
JLLeitschuh
requested changes
Dec 25, 2017
| @@ -24,23 +24,26 @@ | |||
| <rowConstraints> | |||
| <RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="NEVER" /> | |||
| <RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="NEVER" /> | |||
| <RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="NEVER" /> | |||
There was a problem hiding this comment.
This isn't aligned correctly. Tabs vs spaces?
There was a problem hiding this comment.
Hmmm possibly. I didn't edit that file manually so I guess SceneBuilder didn't align. I'll update manually
| outframe.sendCvBGR(img) | ||
|
|
||
| # TODO: send contour report over USB | ||
| # TODO: add parameter(s) to enable/disable individual values of the report over USB |
There was a problem hiding this comment.
Do you plan to do this before this is merged?
There was a problem hiding this comment.
I'd like to yes - I also have some refactoring in the template I'd like to include (using socket type rather than name to determine whether or not to generate the drawing code). I'll amend the commit over the next couple of days; please let me know if any other thins to look at as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to generate an elementary jevois module as part of code generation for the pipeline. This helps simplify use of GRIP pipelines on the jevois.
Currently only Python is supported, and the module is very elementary. The module will: