Use explicit names for elements creating using Builder::make_ methods
#6809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Aug 5, 2024
| @@ -4968,7 +4968,6 @@ BinaryenTableRef BinaryenAddTable(BinaryenModuleRef module, | |||
| BinaryenIndex maximum, | |||
| BinaryenType tableType) { | |||
| auto table = Builder::makeTable(name, Type(tableType), initial, maximum); | |||
| table->hasExplicitName = true; | |||
There was a problem hiding this comment.
I thought it is no longer needed since Builder::makeTable now uses explicit name by default.
|
Turns out this change isn't so simple. Marking as WIP for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all the cases I could find the
make_xxhelper method were called with meaningful names that are useful in the name section.See #6496 and #6806