Skip to content
This repository has been archived by the owner on Jul 1, 2023. It is now read-only.

Set DBName for DB connection #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

olimpias
Copy link

No description provided.

@facebook-github-bot
Copy link
Contributor

Hi @olimpias!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link

@juana9095 juana9095 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Espero poder ver lo k estén bien mis hijos

@mengyiyuan
Copy link
Contributor

Hi @olimpias, thanks for submitting the pull request and sorry for my late reply!
Can you please elaborate a bit more on why you think wadebug should support db name? When you set up the WA Business API client, we don't support the option to specify db name in db.env (https://github.com/mengyiyuan/WhatsApp-Business-API-Setup-Scripts/blob/master/installation/db.env). I think wadebug should mirror what is supported by the WA Business API client as closely as possible.
Thanks!

@olimpias
Copy link
Author

Hi @mengyiyuan , I have created this MR based on statement

WA_DB_NAME_PREFIX — Can be used to prefix all databases created when the WhatsApp Business API client is installed. It can be used to run multiple sets of WhatsApp Business API databases on the same database host.

Currently, WA-debugger is not supporting multiple database support on a single database host. I think this MR allow us to debug specific database on a multiple databases hosted host.

Copy link

@ankit-gautam23 ankit-gautam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants