Show submitted date in Plugin Controls #369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellyworth
reviewed
Sep 25, 2024
| @@ -192,6 +192,11 @@ protected static function display_meta() { | |||
| <td><strong><?php printf( '<span title="%s">%s ago</span>', esc_attr( $post->last_updated ), human_time_diff( strtotime( $post->last_updated ) ) ); ?></strong></td> | |||
| </tr> | |||
|
|
|||
| <tr> | |||
| <td><?php _e( 'Submitted:', 'wporg-plugins' ); ?></td> | |||
| <td><strong><?php printf( '<span title="%s">%s ago</span> (%s)', esc_attr( $post->_submitted_date ), human_time_diff( strtotime( $post->_submitted_date ) ), esc_html( gmdate( 'Y/m/d g:i a', $post->_submitted_date ?? 0 ) ) ); ?></strong></td> | |||
There was a problem hiding this comment.
I think the strtotime() is incorrect here; _submitted_date seems to be stored as a unix timestamp rather than a string like last_updated.
There was a problem hiding this comment.
I was not able to setup proper WP local dev setup for "wordpress.org". So I prepared PR just by guessing variables.
There was a problem hiding this comment.
Appreciate if you could edit the PR and update as required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta ticket: https://meta.trac.wordpress.org/ticket/7761