🐛fix air conditioner sound can't turning off completely & use valtio instead of context #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for air-conditioner ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
YunYouJun
reviewed
Nov 27, 2022
|
集成了Valtio作为状态管理的方案 |
boyfeiyu
changed the title
YunYouJun
reviewed
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#152
修复了152issue提到的独立遥控器和主页面的遥控器控制声音不同步的问题
思路是将播放声音的组件放在空调内部，并且状态抽取到Context中进行管理。
如果是在独立遥控器触发开关，通过监听storage来通知空调播放声音。
前端新手，云游大大您看这样做是否合理qaq