Merge pull request #1189 from abraham/media_id

Check Twitter response in uploadMediaChunked
abraham · Jul 24, 2023 · 233bd80 · 233bd80
2 parents 5188963 + 13ed24c
commit 233bd80
Show file tree

Hide file tree

Showing 3 changed files with 71 additions and 0 deletions.
diff --git a/src/TwitterOAuth.php b/src/TwitterOAuth.php
@@ -364,13 +364,17 @@ private function uploadMediaNotChunked(string $path, array $parameters)
      */
     private function uploadMediaChunked(string $path, array $parameters)
     {
+        /** @var object $init */
         $init = $this->http(
             'POST',
             self::UPLOAD_HOST,
             $path,
             $this->mediaInitParameters($parameters),
             false,
         );
+        if (!property_exists($init, 'media_id_string')) {
+            throw new TwitterOAuthException('Missing "media_id_string"');
+        }
         // Append
         $segmentIndex = 0;
         $media = fopen($parameters['media'], 'rb');

diff --git a/tests/TwitterOAuthMediaTest.php b/tests/TwitterOAuthMediaTest.php
@@ -88,4 +88,22 @@ public function testPostStatusesUpdateWithMediaChunked()
         $result = $this->twitter->post('statuses/destroy/' . $result->id_str);
         return $result;
     }
+
+    /**
+     * @vcr testPostStatusesUpdateWithMediaChunkedException.json
+     */
+    public function testPostStatusesUpdateWithMediaChunkedException()
+    {
+        $this->expectException(
+            \Abraham\TwitterOAuth\TwitterOAuthException::class,
+        );
+        $this->expectErrorMessage('Missing "media_id_string"');
+        // Video source http://www.sample-videos.com/
+        $file_path = __DIR__ . '/video.mp4';
+        $result = $this->twitter->upload(
+            'media/upload',
+            ['media' => $file_path, 'media_type' => 'video/mp4'],
+            true,
+        );
+    }
 }
diff --git a/tests/fixtures/testPostStatusesUpdateWithMediaChunkedException.json b/tests/fixtures/testPostStatusesUpdateWithMediaChunkedException.json
@@ -0,0 +1,49 @@
+[{
+    "request": {
+        "method": "POST",
+        "url": "https:\/\/upload.twitter.com\/1.1\/media\/upload.json",
+        "headers": {
+            "Host": "upload.twitter.com",
+            "Accept": "application\/json",
+            "Authorization": "OAuth oauth_version=\"1.0\", oauth_nonce=\"2b67ebbeace76543f356ba8bbd59abde\", oauth_timestamp=\"1587861062\", oauth_consumer_key=\"awJfND4zFGapGOFKfdjg\", oauth_token=\"93915746-KjE3c27dCt8awONxuUAaJ00yishXXwcH5CdLBnO1x\", oauth_signature_method=\"HMAC-SHA1\", oauth_signature=\"cOKZmxZ5f3bxiwWU%2B1cJ9hWpUL4%3D\"",
+            "Expect": null
+        },
+        "body": "command=INIT&media_type=video%2Fmp4&total_bytes=383631"
+    },
+    "response": {
+        "status": {
+            "http_version": "2",
+            "code": "400",
+            "message": ""
+        },
+        "headers": {
+            "cache-control": "no-cache, no-store, must-revalidate, pre-check=0, post-check=0",
+            "content-disposition": "attachment; filename=json.json",
+            "content-encoding": "gzip",
+            "content-length": "101",
+            "content-type": "application\/json;charset=utf-8",
+            "date": "Sun, 26 Apr 2020 00:31:54 GMT",
+            "expires": "Tue, 31 Mar 1981 05:00:00 GMT",
+            "last-modified": "Sun, 26 Apr 2020 00:31:54 GMT",
+            "pragma": "no-cache",
+            "server": "tsa_b",
+            "set-cookie": "personalization_id=\"v1_0CYjFmw6Rjdl\/xKmqvzf4g==\"; Max-Age=63072000; Expires=Tue, 26 Apr 2022 00:31:54 GMT; Path=\/; Domain=.twitter.com; Secure; SameSite=None, lang=en; Path=\/, guest_id=v1%3A158786111466374311; Max-Age=63072000; Expires=Tue, 26 Apr 2022 00:31:54 GMT; Path=\/; Domain=.twitter.com; Secure; SameSite=None",
+            "status": "202 Accepted",
+            "strict-transport-security": "max-age=631138519",
+            "vary": "Origin",
+            "x-access-level": "read-write-directmessages",
+            "x-connection-hash": "448b96791c0d13223e24f9c1edc4a7fa",
+            "x-frame-options": "SAMEORIGIN",
+            "x-mediaid": "1254206535166763008",
+            "x-rate-limit-limit": "200",
+            "x-rate-limit-remaining": "198",
+            "x-rate-limit-reset": "1587864355",
+            "x-response-time": "28",
+            "x-transaction": "009da55c002c6fca",
+            "x-tsa-request-body-time": "1",
+            "x-twitter-response-tags": "BouncerCompliant",
+            "x-xss-protection": "1; mode=block"
+        },
+        "body": "{\"errors\":[{\"code\":324,\"message\":\"Failed to process media.\"}]}"
+    }
+}]