Swift 4.1 Support #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a public message structure to simplify and extend delegate. Add background queue connect convenience method. Have one delegate callback on disconnect. Push errors out to delegate. Rename SessionStream file.
Add BatchReceiver sketch
make optional completion blocks truly optional
…make more structs
adolfo
force-pushed
the
swift_4.1
branch
2 times, most recently
from
b3c2e14
to
d240b39
Compare
adolfo
force-pushed
the
swift_4.1
branch
8 times, most recently
from
46e026a
to
ecdcc66
Compare
|
@bhargavg Can you take a look at this when you a few free moments? |
|
@bhargavg Yes, these were removed intentionally. They weren't documented and because I wasn't familiar with them, I was unable to test them. Because of this I felt uncomfortable including them so for now they still exist in the commit history so they can restored if needed. I also don't see a way to |
|
Ok, I'll review and get this merged first, then we can see what to do with those un-merged PRs. |
|
@bhargavg Thoughts on this? |
|
@bhargavg If there are no objections I'd like to merge this and publish a new version to CocoaPods. Thoughts? |
Michael-AirMap
approved these changes
Aug 16, 2018
|
@bhargavg @Michael-AirMap I'm going to merge this and cut a new release. |
This was referenced Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates changes from:
#23 Many lifecycle fixes and optimizations
#30 Add Swift 4 Support
Also addresses:
#31 Sample app does not compile
#28 Add Swift Package Manager support
#21 Connect or subscribe don't get callbacks when in thread other than main