-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add string[] option to submodules #1866
base: main
Are you sure you want to change the base?
Conversation
ba4104a
to
03f9a47
Compare
Allows checking out only specific submodules instead of all
03f9a47
to
b6625bb
Compare
9c15e92
to
7618b1f
Compare
Any reason not to move forward with the integration of this PR? I would really like this feature, since my project has ~20 submodules (some with its own submods), and I only need a hanfdul for my workflow. Thanks! |
Any chance this can be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gracias
Any update on this? |
@joshmgross @jww3 I picked your names since you are listed as the two major contributors in the last 6 months. Do you know who we should ping to take a look at this? I don't even see checks triggered, which makes me think that the repo protection rules are set so that actions don't start until a review is given. I don't want to pressure you, since I'm sure you have your fair share of daily work. I just don't know what the process is to get a PR moving. I don't know much (read: anything) about node.js, so I can't tell if this PR is following the CONTRIBUTING.md guidance of keeping PR limited to one logical set of changes or not. Hence, maybe that's why the PR didn't get any attention: because it's not conforming to the standard (understandable)? Or maybe simply repo maintainers don't have the time to keep up with the amount of PRs (also understandable)? Thanks, and sorry for pulling you in. I just don't know if this PR is dead or just that things move slowly. |
👋 Hey @bartgol, Apologies for the lack of a response here. Feature requests should be done through an issue and we use that to judge interest before deciding to add to this action. If you're blocked on needing this feature, then I'd recommend forking this action, validating these changes, and using that forked action in your workflow. I realize that's not an ideal situation. |
@joshmgross I was not aware of that. I have opened another issue for the request here: #1969 |
Allows checking out only specific submodules instead of all