fix: lazy load ProxyAgent to avoid bundling all the undici #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
commented
Aug 18, 2024
Comment on lines
+726
to
+729
| // Lazy load ProxyAgent to avoid bundling all the undici | ||
| const ProxyAgent = | ||
| // eslint-disable-next-line @typescript-eslint/no-require-imports, @typescript-eslint/no-var-requires | ||
| require('undici/lib/proxy-agent') as typeof import('undici/types/proxy-agent').default |
There was a problem hiding this comment.
This can be further improved by using dynamic imports. However, I didn't include it in this pull request, because using dynamic imports needs making getAgentDispatcher async, which changes the return type of a public method. Based on my research, this is only used in the github package, so it should be fine, but if we want to go with that, we need to have a major version bump for http-client.
aminya
added a commit
to aminya/setup-cpp
that referenced
this pull request
Aug 30, 2024
benmccann
reviewed
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the loading of undici conditional by lazy loading it inside the actual function that needs the ProxyAgent.
undici is a huge library, and here it is being imported unconditionally, which results in 500KB bloat in the bundles of http-client. By requiring only what is needed and when it is needed, this issue is resolved.
Fixes #1560
Closes #1561