Integrate cache service v2 #1857
Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
packages/cache/src/cache.ts
Outdated
| * @param enableCrossOsArchive an optional boolean enabled to restore on windows any cache created on any platform | ||
| * @returns string returns the key for the cache hit, otherwise returns undefined | ||
| */ | ||
| async function restoreCachev2( |
There was a problem hiding this comment.
Is there an opportunity to share code between restoreCachev1 and restoreCachev2 instead of duplicating it all?
That would make it easier to see what's actually changing and improve long-term maintenance of supporting both paths (such as for GHES).
There was a problem hiding this comment.
I think it's easier to reason about what each function is doing this way. We don't have to couple the behaviour of each with more shared functions. The utility functions are already extracted, and what remains is the procedural implementation.
| workflowRunBackendId: backendIds.workflowRunBackendId, | ||
| workflowJobRunBackendId: backendIds.workflowJobRunBackendId, |
There was a problem hiding this comment.
Do we really need these in the request if they're encoded into the JWT?
There was a problem hiding this comment.
Addressed in: https://github.com/github/actions-relaunch/issues/994
| @@ -45,10 +45,13 @@ | |||
| "@azure/abort-controller": "^1.1.0", | |||
| "@azure/ms-rest-js": "^2.6.0", | |||
| "@azure/storage-blob": "^12.13.0", | |||
| "semver": "^6.3.1" | |||
| "@protobuf-ts/plugin": "^2.9.4", | |||
There was a problem hiding this comment.
These have been moved from the top level package.json. And @protobuf-ts/plugin was bumped up to 2.9.4. Not sure why were using (and still using) @protobuf-ts/plugin": "^2.2.3-alpha.1 in artifacts
Upgrading the cache package to integrate with the new cache service backend (cache service v2). Major changes to the API layer are involved with this change but the interfaces are backward compatible. The transition to the new service will undergo gradual rollout and will be seamless to end users.
More context
Deprecation notice for v1 and v2 of actions/cache