-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add harbor app #878
base: master
Are you sure you want to change the base?
Add harbor app #878
Conversation
cmd/apps/harbor.go
Outdated
return harbor | ||
} | ||
|
||
const HarborInfoMsg = `# Get the Harbor URL and login with the default credentials: admin/Harbor12345` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to generate the credentials?
Can you also add the docs or GitHub repo (whichever is more useful) as a link on a separate line?
Also - we are probably going to want a port-forward command here, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, we can do it. Thanks for the feedback!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted the info section. Credentials can be changed through values, therefore I added a command to obtain them without hardcoding the defaults.
Documentation link is added.
The same goes for port-forward.
Let me know what do you think?
Would we like to get this in before KubeCon @Jasstkn ? Are you attending btw? |
87e2800
to
88c6508
Compare
Signed-off-by: Mariia Kotliarevskaia <[email protected]>
88c6508
to
60f9747
Compare
Hey. Sorry for the delays - was swamped with work and learning activities 🙈. Yep, I'll be there since Tue until evening of Friday. Unfortunately, I booked everything much earlier before Rejekt conference appeared on the radar :( |
harbor.Flags().Bool("update-repo", true, "Update the helm repo") | ||
harbor.Flags().Bool("ingress", false, "Enable ingress") | ||
harbor.Flags().Bool("trivy", false, "Enable trivy") | ||
harbor.Flags().Bool("notary", false, "Enable notary") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notary was removed as of release 2.8 we have replaced it with cosign!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that looks ok for now! Cosign comes by default
Description
Adds harbor to the list of apps
Motivation and Context
design/approved
by a maintainer (required)#874
How Has This Been Tested?
Are you a GitHub Sponsor yet (Yes/No?)
Types of changes
Documentation
./arkade get -o markdown
./arkade install --help
Checklist:
git commit -s