Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add harbor app #878

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Jasstkn
Copy link
Contributor

@Jasstkn Jasstkn commented Mar 30, 2023

Description

Adds harbor to the list of apps

Motivation and Context

  • I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

#874

How Has This Been Tested?

./arkade install harbor
Using Kubeconfig: /Users/mariakot/.kube/config
Using Kubeconfig: /Users/mariakot/.kube/config
[Warning] unable to create namespace harbor, may already exist: Error from server (AlreadyExists): namespaces "harbor" already exists
Client: arm64, Darwin
2023/03/30 21:34:27 User dir established as: /Users/mariakot/.arkade/
"harbor" already exists with the same configuration, skipping

Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "aquasecurity" chart repository
...Successfully got an update from the "teleport" chart repository
...Successfully got an update from the "harbor" chart repository
...Successfully got an update from the "falco" chart repository
...Successfully got an update from the "prometheus-community" chart repository
Update Complete. ⎈Happy Helming!⎈

VALUES values.yaml
Command: /Users/mariakot/.arkade/bin/helm [upgrade --install harbor harbor/harbor --namespace harbor --values /var/folders/1s/pldd8rv567n2qf3plqr_p6kc76tdnn/T/charts/harbor/values.yaml --set chartmuseum.enabled=false --set expose.type=clusterIP --set externalURL=harbor --set trivy.enabled=false --set notary.enabled=false --set persistence.enabled=false --set expose.tls.auto.commonName=harbor]
Release "harbor" has been upgraded. Happy Helming!
NAME: harbor
LAST DEPLOYED: Wed Apr 12 09:02:43 2023
NAMESPACE: harbor
STATUS: deployed
REVISION: 6
TEST SUITE: None
NOTES:
Please wait for several minutes for Harbor deployment to complete.
Then you should be able to visit the Harbor portal at harbor
For more details, please visit https://github.com/goharbor/harbor
=======================================================================
=                     Harbor has been installed.                       =
=======================================================================

Please wait for several minutes for Harbor deployment to complete.
Then you should be able to visit the Harbor portal at https://harbor.<your-domain>/ or via kubectl port-forward:
kubectl port-forward -n harbor svc/harbor 8081:443

# use https when port-forwarding, e.g.
https://localhost:8081

To login, get the admin password by running: 
kubectl get secrets -n harbor harbor-core -o jsonpath="{.data.HARBOR_ADMIN_PASSWORD}" | base64 -d

For more details, please visit https://github.com/goharbor/harbor


🐳 arkade needs your support: https://github.com/sponsors/alexellis

Screenshot 2023-03-30 at 21 37 09

Are you a GitHub Sponsor yet (Yes/No?)

  • Yes
  • No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

return harbor
}

const HarborInfoMsg = `# Get the Harbor URL and login with the default credentials: admin/Harbor12345`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to generate the credentials?

Can you also add the docs or GitHub repo (whichever is more useful) as a link on a separate line?

Also - we are probably going to want a port-forward command here, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we can do it. Thanks for the feedback!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted the info section. Credentials can be changed through values, therefore I added a command to obtain them without hardcoding the defaults.

Documentation link is added.

The same goes for port-forward.

Let me know what do you think?

@alexellis
Copy link
Owner

Would we like to get this in before KubeCon @Jasstkn ?

Are you attending btw?

Signed-off-by: Mariia Kotliarevskaia <[email protected]>
@Jasstkn
Copy link
Contributor Author

Jasstkn commented Apr 12, 2023

Would we like to get this in before KubeCon @Jasstkn ?

Are you attending btw?

Hey. Sorry for the delays - was swamped with work and learning activities 🙈. Yep, I'll be there since Tue until evening of Friday. Unfortunately, I booked everything much earlier before Rejekt conference appeared on the radar :(

harbor.Flags().Bool("update-repo", true, "Update the helm repo")
harbor.Flags().Bool("ingress", false, "Enable ingress")
harbor.Flags().Bool("trivy", false, "Enable trivy")
harbor.Flags().Bool("notary", false, "Enable notary")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notary was removed as of release 2.8 we have replaced it with cosign!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info @OrlinVasilev

Anything else we need to know?

@Jasstkn want to swap it out?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks ok for now! Cosign comes by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants