Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Jan copy (improved README, simplified configuration, handle validation) #26

Merged
merged 21 commits into from
Nov 13, 2024

Conversation

jancurn
Copy link
Member

@jancurn jancurn commented Oct 31, 2024

No description provided.

@jirispilka
Copy link
Collaborator

@jancurn Thanks a lot! I like the improved structure, it’s definitely better now. Usage -> Normal Mode and Usage -> Standby Mode, cool.

I also like the feature list with emojis as it adds a nice touch.

I've included an Output example at the top so users can quickly see what they’ll get.
I also included a link to the OpenAPI schema for Standby Mode rather than pasting the entire schema, as it would take up too much space in the README and could be distracting. I don’t have a strong opinion on this, as I assume people use the right-side navigation for quickly browsing the README.

Let me know, I can change that.

Otherwise we can merge and publish.

@jirispilka
Copy link
Collaborator

@jancurn are you planning to do more work on this PR?

@jirispilka jirispilka mentioned this pull request Nov 12, 2024
jirispilka and others added 2 commits November 13, 2024 13:19
* Add aws-lambda function
* Hide variables initialConcurrency/minConcurrency/maxConcurrency in Actor input and remove them from README.md
* Remove `requestTimeoutContentCrawlSecs` and use only `requestTimeoutSecs`
* Check whether there is time left to wait for dynamical content before Actor timeout (normal mode)
* Rename googleSearchResults to searchResults, rename searchProxyGroup to serpProxyGroup
* Input validation
@jirispilka jirispilka changed the title doc: Jan copy improvements feat: Jan copy (improved README, simplified configuration, handle validation) Nov 13, 2024
@jirispilka jirispilka merged commit abbfc35 into master Nov 13, 2024
1 check passed
@jirispilka jirispilka deleted the feat/copy branch November 13, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants