Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable ARShowCollectedArtistOnboarding and AREnableMyCollectionCollectedArtists #9095

Conversation

olerichter00
Copy link
Contributor

@olerichter00 olerichter00 commented Jul 31, 2023

This PR resolves ONYX-193

Description

This PR enables the two feature flags ARShowCollectedArtistOnboarding and AREnableMyCollectionCollectedArtists.

In case we decide not to release the feature in the next app release, we need to make sure to disable both feature flags before the release.

artsy/echo#509 adds the feature flags to Echo

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Jul 31, 2023

Warnings
⚠️

An error occurred while validating your changelog, please make sure you provided a valid changelog.

Generated by 🚫 dangerJS against b198660

Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I would suggest though keeping this as a draft to make sure we don't accidentally release it unless we're sure.

@olerichter00
Copy link
Contributor Author

LGTM - I would suggest though keeping this as a draft to make sure we don't accidentally release it unless we're sure.

Good idea 👍

Let's keep it as a draft until it's in a state to be released.

@olerichter00 olerichter00 marked this pull request as draft July 31, 2023 12:15
@olerichter00 olerichter00 force-pushed the olerichter00/ONYX-193/enable-arshowcollectedartistonboarding-and-arenablemycollectioncollectedartists branch from ed36fdd to b198660 Compare August 1, 2023 11:18
@olerichter00 olerichter00 marked this pull request as ready for review August 2, 2023 12:30
@olerichter00
Copy link
Contributor Author

@olerichter00 olerichter00 merged commit eb67e8f into main Aug 3, 2023
1 check passed
@olerichter00 olerichter00 deleted the olerichter00/ONYX-193/enable-arshowcollectedartistonboarding-and-arenablemycollectioncollectedartists branch August 3, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants