-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReadMe update for minimum version supported #831
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #831 +/- ##
===========================================
- Coverage 61.46% 32.32% -29.15%
===========================================
Files 277 271 -6
Lines 10666 10611 -55
Branches 1486 1476 -10
===========================================
- Hits 6556 3430 -3126
- Misses 3569 6892 +3323
+ Partials 541 289 -252 ☔ View full report in Codecov by Sentry. |
@@ -8,7 +8,7 @@ This repository contains the AWS Deploy Tool for .NET CLI - the opinionated tool | |||
|
|||
The tool assumes minimal knowledge of AWS. It is designed to guide you through the deployment process and provides suggested defaults. The tool will show you all compute service options available to deploy your application, and will recommend a default with information about why it was chosen. The other compute service options will be shown with an explanation of their differences. If the selected compute option does not match your needs, you can select a different compute service. | |||
|
|||
The goal of the deployment tool is to deploy cloud-native .NET applications that are built with .NET Core 3.1 and above. A cloud-native .NET application is written in .NET with the intent to deploy to Linux. It is not tied to any Windows specific technology such as Windows registry, IIS or MSMQ, and can be deployed on virtualized compute. The tool **cannot** be used to deploy .NET Framework, Desktop, Xamarin, or other applications that do not fit the "cloud-native" criteria. | |||
The goal of the deployment tool is to deploy cloud-native .NET applications that are built with .NET Core 6 and above. A cloud-native .NET application is written in .NET with the intent to deploy to Linux. It is not tied to any Windows specific technology such as Windows registry, IIS or MSMQ, and can be deployed on virtualized compute. The tool **cannot** be used to deploy .NET Framework, Desktop, Xamarin, or other applications that do not fit the "cloud-native" criteria. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still support back to .NET Core 3.1 in the recipes themselves.
aws-dotnet-deploy/src/AWS.Deploy.Recipes/RecipeDefinitions/ASP.NETAppAppRunner.recipe
Line 36 in c512b3c
"AllowedValues": [ "netcoreapp3.1", "net5.0", "net6.0", "net7.0", "net8.0" ] |
Should we actually drop support? Previously we didn't because even though the runtime is EOL, we didn't want to pull the rug out from under users who may still be updating older applications. But on the other hand we may not want our support matrix to grow indefinitely...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll look at how many recipes for 3.1 are being used and make that determination.
Closing as .NET Core 3.1 is supported in the recipes. |
…T 6 and above.
Issue #, if available:
Description of changes:
Updated the ReadMe file to explain the minimum version supported is .NET 6
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.