fix: headerBasedAuth not updating the headers with new values #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #666 |
|
This should be applied as a hotfix to |
|
The Amplify docs still advises to use this repo when using Apollo Client: https://docs.amplify.aws/lib/graphqlapi/upgrade-guide/q/platform/js/#option-2-upgrade-to-apollo-client-with-appsync-links Wouldn't it make sense to merged this PR then? Or is there by now an alternative advised approach of how to use Apollo Client with AppSync? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#666
Description of changes:
Allows the
headerBasedAuthfunction to actually update the headers with the new value.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.