Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix/quest_template_addon) Quest: Morgan Stern [1260] - Optional #20579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheSCREWEDSoftware
Copy link
Contributor

@TheSCREWEDSoftware TheSCREWEDSoftware commented Nov 15, 2024

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue

  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

  • Make an alliance character

  • .level 30

  • .go creature id 4794

  • Talk to Morgan Stern, now you're able to start the Quest Mudrock Soup and Bugs without the previous quest.

@TheSCREWEDSoftware TheSCREWEDSoftware changed the title Makes the quest optional Quest: Morgan Stern [1260] - Optional Nov 15, 2024
@TheSCREWEDSoftware TheSCREWEDSoftware changed the title Quest: Morgan Stern [1260] - Optional (fix/quest_template_addon) Quest: Morgan Stern [1260] - Optional Nov 15, 2024
@github-actions github-actions bot added the DB related to the SQL database label Nov 15, 2024
@TheSCREWEDSoftware
Copy link
Contributor Author

TheSCREWEDSoftware commented Nov 15, 2024

Have to do another fix

Edit: The check already exists in the quest if quest 1204 gets completed before getting 1260 it won't show you the 1260 quest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database Ready to be Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant