Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(redhat-argocd): remove @janus-idp/cli and dynamic plugin build step #1845

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+55 −1,345
Draft

refactor(redhat-argocd): remove @janus-idp/cli and dynamic plugin build step #1845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions workspaces/redhat-argocd/.changeset/hungry-berries-cross.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@backstage-community/plugin-redhat-argocd': patch
---

Removed `export-dynamic` script and Janus IDP cli from the build process and npm release.
0 ...rgocd/app-config.backstage-community.yaml → ...cd/plugins/argocd/app-config.dynamic.yaml
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion workspaces/redhat-argocd/plugins/argocd/knip-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,5 @@
| :-------------------------- | :----------- | :------- |
| @testing-library/user-event | package.json | error |
| @backstage/core-app-api | package.json | error |
| @janus-idp/cli | package.json | error |
| react-dom | package.json | error |
| msw | package.json | error |
9 changes: 3 additions & 6 deletions workspaces/redhat-argocd/plugins/argocd/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,9 @@
"scripts": {
"build": "backstage-cli package build",
"clean": "backstage-cli package clean",
"export-dynamic": "janus-cli package export-dynamic-plugin --in-place",
christoph-jerolimov marked this conversation as resolved.
Show resolved Hide resolved
"lint": "backstage-cli package lint",
"postpack": "backstage-cli package postpack",
"prepack": "backstage-cli package prepack && yarn run export-dynamic",
"prepack": "backstage-cli package prepack",
"start": "backstage-cli package start",
"test": "backstage-cli package test --passWithNoTests --coverage",
"tsc": "tsc",
Expand Down Expand Up @@ -65,7 +64,6 @@
"@backstage/core-app-api": "^1.15.1",
"@backstage/dev-utils": "^1.1.2",
"@backstage/test-utils": "^1.7.0",
"@janus-idp/cli": "1.13.1",
"@playwright/test": "1.46.1",
"@redhat-developer/red-hat-developer-hub-theme": "0.2.0",
"@testing-library/jest-dom": "6.6.2",
Expand All @@ -78,10 +76,9 @@
"react-router-dom": "^6.3.0"
},
"files": [
"dist",
"app-config.dynamic.yaml",
"config.d.ts",
"dist-scalprum",
"app-config.backstage-community.yaml"
"dist"
],
"scalprum": {
"name": "backstage-community.plugin-redhat-argocd",
Expand Down
Loading
Loading