This repository has been archived by the owner on Apr 1, 2019. It is now read-only.
Added option to retrieve boolean response from JSON content #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've had problems building the solution because of some GPG plugin problem but I've tested the pull request otherwise directly from Eclipse and it worked OK. |
| /* Parse and return a boolean value | ||
| /* | ||
| public boolean bool() throws IOException, JSONException { | ||
| return (boolean)unmarshal(); |
There was a problem hiding this comment.
I think unmarshal() should only be called if it hasn't been unmarshalled already, and the value cached in json be cast and returned
if (json == null) unmarshal();
return (boolean)json;
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
sometimes the content returned is a constant true/false. Since there is no way to set the content type for TextResource I've created the "toBoolean" method on JSONResource that simply casts the unmarshaled object to boolean.
I need this since the service I am integrating with is very strict in the content it accepts and can produce (application/json and nothing else) and returns a true/false value.
Best regards,
Matthias.