This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
Incomplete Index Component System (ICS) #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concepts can be checked using Concept<Type> instead of creating a function
mrzzy
reviewed
Nov 7, 2020
mrzzy
reviewed
Nov 8, 2020
mrzzy
reviewed
Nov 8, 2020
mrzzy
reviewed
Nov 8, 2020
mrzzy
reviewed
Nov 8, 2020
mrzzy
reviewed
Nov 8, 2020
mrzzy
reviewed
Nov 8, 2020
Parent and child component is replaced with a generic test component
|
LGTM 👍 . Merge at will |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created the basic implementation of indexes and components along with their tests in this PR.
The CMakeLists file has also been split up. Each subdirectory of sim/src will have its own CMakeLists file. Each subdirectory represents a library that is supposed to be independent of any other adjacent directories. Currently I have
icswhich stores the core ics concepts and structs andutilwhich stores utility types.Each subdirectory is interpreted as a library in the main CMakeLists file.