do-not-merge #2
Open
do-not-merge #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I now kinda realized maybe you have abanboned source/goodsoup and just focusing on source/gs considering the recent commit history? I see that it basically is just the bare bones so far but it looks very promising, I like C hell of a lot more than C++ and it is obvious more thought has gone into gs than the old version. |
This made things like ./monkey 114 play using SDL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just wrote this pull request to ask some questions.
So I run on Linux using SDL. I couldnt get the videos running using ./monkey 114 for example but changing this made it work (otherwise it would just crash because the value return could be negative).
When looking into the endian.c code, it was a bit confusing as well. I am not sure it actually works as it should. For instance the read in16 functions returns uint16 which is kinda strange. What do you think?