Add trace_id and status field values to ExtractGethTracesJob #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajithaliyanage
force-pushed
the
develop
branch
from
e94700b
to
99f67ec
Compare
|
@medvedev1088 please review and merge this PR. This is useful for extracting contracts from traces, as deriving contracts from receipts does not give all contracts in the blockchain. Similar fix is already merged in Ethereum ETL airflow dags blockchain-etl/ethereum-etl-airflow#8 |
|
@medvedev1088 tried this fix and it works fine, could you please consider reviewing? Thanks @sajithaliyanage! |
| @@ -51,6 +54,10 @@ def _extract_geth_traces(self, geth_traces): | |||
| for geth_trace_dict in geth_traces: | |||
| geth_trace = self.geth_trace_mapper.json_dict_to_geth_trace(geth_trace_dict) | |||
| traces = self.trace_mapper.geth_trace_to_traces(geth_trace) | |||
|
|
|||
| calculate_trace_statuses(traces) | |||
There was a problem hiding this comment.
Geth traces don't have transaction_hash in them so status calculation is not correct. calculate_trace_statuses needs to be accommodated to geth traces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, This fix is needed to run the
extract_contractscommand since it checks the status to filter out contracts from the traces. Refer:ethereum-etl/ethereumetl/jobs/extract_contracts_job.py
Line 62 in 956695b