Fix TransferManager.cancel passing bad parameters to _shutdown #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkza
force-pushed
the
fix-transfer-manager-cancel
branch
from
4a434d6
to
fb19365
Compare
danielkza
force-pushed
the
fix-transfer-manager-cancel
branch
from
fb19365
to
670cf58
Compare
|
@nateprewitt Sorry for tagging you directly. This is a blatant bug. Could you merge the fix please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the
cancelboolean twice tries to pass a string as the exception class, which eventually crashes when creating an instance of it is attempted.