Returned ETag for uploaded entities #244
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
tasks.CompleteMultipartUploadTask
andupload.PutObjectTask
.Background
boto3
to return ETag information for several call sites, i.e.: S3 upload_file() and upload_fileobj() do not return the object's ETag. boto3#2861.s3transfer
to return the ETag information at the call sites changed in this Pull Request.boto3
is related, which I have submitted separately here: Returned future result in S3Transfer's download and upload boto3#3316. The two pull requests are completely decoupled, so can be merged in any order or independently.Design decisions
upload.UploadPartTask
, i.e. a pattern already in the codebase. This pattern returns the ETag inside an outermetadata
dictionary.