Consolidating ErrorTracker methods into single method call (SCP-3378)

[bistline]

This update consolidates the usage of ErrorTracker for reporting errors to Sentry into a single method call of report_exception_with_context, removing the need to call format_extra_context before reporting each exception. The new merged method will take any number of "context objects", being instances of models, request parameters, or any other object. This makes using the module easier and still reports necessary context along with errors.

TO TEST:

As we do not report exceptions in development/test mode, the simplest way to test this is by invoking the method directly:

1. Enter the rails console
2. Load an assortment of objects for reporting:

user = User.first
study = Study.first
file = StudyFile.first
extra = {foo: 'bar'}

3. Create an exception:

error = RuntimeError.new('this is the error')

4. Using the data from above, report the exception:

ErrorTracker.report_exception_with_context(error, user, study, file, extra)

5. Note the following message in development.log:

Suppressing error reporting to Sentry: RuntimeError:this is the error, context: {"study" => {...}, "study_file" => {...}, :foo => "bar"}

This PR satisfies SCP-3378.

[codecov]

Codecov Report

Merging #1046 (8737978) into development (db15f39) will increase coverage by 0.23%.
The diff coverage is 10.63%.

@@               Coverage Diff               @@
##           development    #1046      +/-   ##
===============================================
+ Coverage        64.85%   65.09%   +0.23%     
===============================================
  Files              181      181              
  Lines            16505    16425      -80     
  Branches           601      601              
===============================================
- Hits             10705    10692      -13     
+ Misses            5608     5541      -67     
  Partials           192      192              

Impacted Files	Coverage Δ
app/controllers/admin_configurations_controller.rb	33.66% <0.00%> (ø)
.../controllers/analysis_configurations_controller.rb	44.21% <0.00%> (+1.35%)	⬆️
app/controllers/api/v1/api_base_controller.rb	82.75% <0.00%> (ø)
...ontrollers/api/v1/directory_listings_controller.rb	96.61% <0.00%> (ø)
...ontrollers/api/v1/external_resources_controller.rb	96.53% <0.00%> (+0.47%)	⬆️
app/controllers/api/v1/site_controller.rb	77.19% <0.00%> (+0.75%)	⬆️
app/controllers/api/v1/studies_controller.rb	86.37% <0.00%> (+0.44%)	⬆️
...ontrollers/api/v1/study_file_bundles_controller.rb	95.80% <0.00%> (+0.57%)	⬆️
app/controllers/api/v1/study_files_controller.rb	92.44% <0.00%> (+0.24%)	⬆️
app/controllers/api/v1/study_shares_controller.rb	96.24% <0.00%> (+0.44%)	⬆️
... and 28 more

[bistline]

There appears to be an intermittent issue with precompiling static assets in sprockets 4 - on rare occasions a segfault is thrown. This is apparently a known issue: rails/sprockets#633.

We should keep an eye on this as it could happen in any of our deployed environments.

[devonbush]

this is great! Couple nits -- I'm not sure I understand why in some cases you kept .to_unsafe_hash, and in others you removed it. And then just a method naming preference that could go either way

[eweitz]

Looks good. Following up on our recent discussion about straggling unnecessary#{Time.zone.now}: prefixes in error messages, below I've removed the 43 cases here and tweaked remaining message content accordingly.

That feedback can be trivially applied via "Add suggestion to batch" and "Commit suggestions".

[devonbush]

Looks good! I wouldn't be averse to yet another round of consolidation where the ErrorTracker also handles writing the log message. But that's a very-low-importance task for another day.