PBL+weval: fix a few more value-specialization cases on conditionals. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfallin
added a commit
to bytecodealliance/spidermonkey-wasi-embedding
that referenced
this pull request
Aug 2, 2024
This pulls in bytecodealliance/gecko-dev#56.
cfallin
added a commit
to cfallin/StarlingMonkey
that referenced
this pull request
Aug 2, 2024
cfallin
force-pushed
the
cfallin/fix-more-conditionals
branch
2 times, most recently
from
cb747ed
to
d9f033c
Compare
When processed with wasm-opt, a few more conditionals have some interesting optimizations that inhibit weval from deducing a constant PC unless we also value-specialized in these places. Rebasing note: preparations-for-weval series rather than actual weval patch.
cfallin
force-pushed
the
cfallin/fix-more-conditionals
branch
from
d9f033c
to
32f3b68
Compare
cfallin
added a commit
to bytecodealliance/spidermonkey-wasi-embedding
that referenced
this pull request
Aug 2, 2024
This pulls in bytecodealliance/gecko-dev#56.
cfallin
added a commit
to bytecodealliance/StarlingMonkey
that referenced
this pull request
Aug 2, 2024
JakeChampion
approved these changes
Aug 2, 2024
cfallin
added a commit
to bytecodealliance/spidermonkey-wasi-embedding
that referenced
this pull request
Aug 2, 2024
This pulls in bytecodealliance/gecko-dev#56.
cfallin
added a commit
to bytecodealliance/StarlingMonkey
that referenced
this pull request
Aug 2, 2024
cfallin
added a commit
to bytecodealliance/StarlingMonkey
that referenced
this pull request
Aug 2, 2024
Update upstream SpiderMonkey and weval for a PBL+weval fix. Pulls in bytecodealliance/gecko-dev#56.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processed with wasm-opt, a few more conditionals have some interesting optimizations that inhibit weval from deducing a constant PC unless we also value-specialized in these places.
Rebasing note: preparations-for-weval series rather than actual weval patch.