Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First step; ruby support #1183

Closed
wants to merge 1 commit into from

Conversation

justincan
Copy link

Still pretty early, not ready for real use.

@come-maiz
Copy link
Contributor

Thanks @justincan. I'm okay landing this to get started, but it needs tests.
To start, you can look at integration_tests and add a build for a basic ruby hello world.
Feel free to let me know if you need a hand.

@sergiusens
Copy link
Collaborator

any update on this

@justincan
Copy link
Author

I have some improvements and tests that I can add to this PR. Still more to make it solid though.


def env(self, root):
ruby_paths = self.run_output(['ruby', '-e', 'puts $:']).split(os.linesep)
ruby_paths = ':'.join(['$SNAP' + x for x in ruby_paths])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it will break terribly if one is using RVM, no?

},
'default': [],
}
schema['properties']['will-install-gems'] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand what this option does. It has "gems" in the name, but really just seems to optionally add build packages to stage packages. What does that have to do with gems?

@kyrofa
Copy link
Contributor

kyrofa commented Jun 14, 2017

Closing due to inactivity. Please reopen when you're ready to continue.

@kyrofa kyrofa closed this Jun 14, 2017
@come-maiz
Copy link
Contributor

For the record, here's our experiment with a ruby snap: travis-ci/travis.rb#515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants