-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First step; ruby support #1183
First step; ruby support #1183
Conversation
Thanks @justincan. I'm okay landing this to get started, but it needs tests. |
any update on this |
I have some improvements and tests that I can add to this PR. Still more to make it solid though. |
|
||
def env(self, root): | ||
ruby_paths = self.run_output(['ruby', '-e', 'puts $:']).split(os.linesep) | ||
ruby_paths = ':'.join(['$SNAP' + x for x in ruby_paths]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like it will break terribly if one is using RVM, no?
}, | ||
'default': [], | ||
} | ||
schema['properties']['will-install-gems'] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand what this option does. It has "gems" in the name, but really just seems to optionally add build packages to stage packages. What does that have to do with gems?
Closing due to inactivity. Please reopen when you're ready to continue. |
For the record, here's our experiment with a ruby snap: travis-ci/travis.rb#515 |
Still pretty early, not ready for real use.