feat: Implemented synced enforcer #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yash Pandey (YP) <[email protected]>
Signed-off-by: Yash Pandey (YP) <[email protected]>
Signed-off-by: Yash Pandey (YP) <[email protected]>
Signed-off-by: Yash Pandey (YP) <[email protected]>
Signed-off-by: Yash Pandey (YP) <[email protected]>
EmperorYP7
force-pushed
the
EmperorYP7/enforcer
branch
from
884e4d6
to
4ebf55e
Compare
Signed-off-by: Yash Pandey (YP) <[email protected]>
|
@bokket feel free to commit on this branch. I am sure there's a lot of room for improvement here. |
Signed-off-by: EmperorYP7 <[email protected]>
Signed-off-by: EmperorYP7 <[email protected]>
Signed-off-by: EmperorYP7 <[email protected]>
EmperorYP7
commented
Mar 16, 2021
| // SetWatcher sets the current watcher. | ||
| void SyncedEnforcer ::SetWatcher(shared_ptr<Watcher> w){ | ||
| watcher = w; | ||
| return watcher->SetUpdateCallback(&SyncedEnforcer::UpdateWrapper); |
There was a problem hiding this comment.
@xcaptain I think this would be of some context to #38 (comment).
There was a problem hiding this comment.
@EmperorYP7 Nice, and I think you can also add SetWatcher to enforcer
|
Plz provide smaller PRs. |
|
🎉 This issue has been resolved in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yash Pandey (YP) [email protected]
This PR fixes #38
Most of the functions of SyncedEnforcer were straight-forward to implement but the
AutoLoadPolicyneeded a workaround since it utilized GoLang's ticker from the "time" module and concurrency. For this, I created a custom concurrent ticker that takes in the duration and afunction<void()>for a callback. Then passed in the following to callback of ticker which is called at every tick:Note that
nis anatomic_intwhich is thread-safe.When
StopAutoLoad()is called, the ticker stops all worker threads deployed by the ticker. However, this won't destroy the instance of the ticker. I also created test files to verify everything is implemented correctly. (The test policy won't change in real-time during a test)Overheads involved:
Apart from the futures obtained from ticker threads, ticker also collects futures from callback at each tick since they're called asynchronously as well. This might lead to a pile of useless data given enough uptime of
AutoLoadPolicy()and scope ofSyncedEnforcer.Tasks remaining
BatchEnforcer,BatchWithMatcheryet to be implemented inEnforcer.UpdatePolicy,UpdateNamedPolicy,UpdatePoliciesandUpdateNamedPoliciesyet to be implemented inEnforcer.UpdateGroupingPolicy,UpdateNamedGroupingPolicyyet to be implemented inEnforcer.I'll implement this in another PR 'cause this is enormous already.