-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make extract_atom, extract_global, and gather typestable #65
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 73.12% 72.81% -0.31%
==========================================
Files 2 2
Lines 480 493 +13
==========================================
+ Hits 351 359 +8
- Misses 129 134 +5 ☔ View full report in Codecov by Sentry. |
I had to use Symbols instead of Strings as the constant propagation didn't work otherwise. I decided to make this a universal change. |
I managed to make
extract_atom
,extract_global
, andgather
typestable through constant propagation. These changes are unavoidably breaking, but I strongly believe that this is for the better.I still have to update documentation and a few checks I probably also need to check that I haven't messed up anywhere but everything seems to be working at least.
I think we could also have a similar issue with cache invalidation as we have with BIGINT etc. But I'm not familiar enough with the internals of julia to know for sure.
I'd like to know your opinion on this @vchuravy
(P.s. I'm sorry for the large and messy PR)