routing: Support alternatives for single-mode routing calculations #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires to pass down the trip routing query attributes all the way down to the OSRM call. It is added as an optional parameter at the end of the `route` and other calculation functions, as well as in the socket route for routing calculation. If the `withAlternatives` attribute is `true` , the osrm backend call sets the alternatives attribute to `true`.
| public async route( | ||
| params: transitionRouteOptions, | ||
| routingAttributes?: TripRoutingQueryAttributes | ||
| ): Promise<Status.Status<osrm.RouteResults>> { |
There was a problem hiding this comment.
Instead of adding a new parameter, we already have the params object which include the boolean for alternatives. We should probably fill it in there before calling this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires to pass down the trip routing query attributes all the way down to the OSRM call. It is added as an optional parameter at the end of the
routeand other calculation functions, as well as in the socket route for routing calculation.If the
withAlternativesattribute istrue, the osrm backend call sets the alternatives attribute totrue.