Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small fixes #889

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Conversation

tahini
Copy link
Collaborator

@tahini tahini commented Mar 22, 2024

In preparation for #408, here's a few unrelated issues.

Note that the update of the target for react packages is also part of PR #773 where the animated path did not work without.

This has been deprecated for a while and is not used anymore.
That's the target of the other packages.
And unit tests fail when a class extends a class from other targets
@tahini tahini requested a review from kaligrafy March 22, 2024 17:40
This function is not used anywhere, the `transitPaths.getForServices` is
currently the way to fetch from server the services for a given scenario.
The Status object is the preferred way to communicate between server and
client and handle error and proper response unwrapping.
@tahini tahini merged commit 3f2cd34 into chairemobilite:main Mar 22, 2024
4 checks passed
@tahini tahini deleted the preDisplayCollection branch March 22, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants