Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: develop Tetragon Enterprise page #3103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

annaindistress
Copy link
Contributor

@annaindistress annaindistress commented Nov 12, 2024

Describe what changes this pull request brings

  • Add Enterprise page
  • Update Welcome to the community! section

Steps to check:

  1. Open preview
  2. Make sure that everything looks and works as expected

@annaindistress annaindistress requested review from mtardy and a team as code owners November 12, 2024 12:53
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 937a8d4
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6735be1d6fc9e2000868e9c7
😎 Deploy Preview https://deploy-preview-3103--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@annaindistress annaindistress force-pushed the enterprise-page branch 2 times, most recently from 228b809 to 6076ca6 Compare November 12, 2024 14:37
<a class="social__link" href="https://isovalent.com/labs/tetragon-getting-started/" target="_blank"
rel="noopener noreferrer">
<img src="/svgs/social/lab-icon.svg" width="64" height="64" loading="lazy" alt="" />
<span>Explore Tetragon&nbsp;lab</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<span>Explore Tetragon&nbsp;lab</span>
<span>Explore Tetragon&nbsp;labs</span>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@mtardy mtardy added area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation. labels Nov 12, 2024
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically looks good, not sure repeating the community thing in the enterprise is important but if it's what was decided I have no strong feeling.

If we can avoid copy pasting as well that would be great.

</li>
</ul>
</div>
<h2 class="title social__title">Welcome to the community!</h2>
Copy link
Member

@mtardy mtardy Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could use a shortcode to reuse that in multiple pages instead of copy pasting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - used a shortcode for the social section

Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait for an ack from @xmulligan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants