-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MQTT Binding. #513
base: main
Are you sure you want to change the base?
MQTT Binding. #513
Conversation
@JemDay LGTM. This is a neat contribution, thanks! |
Thanks @Alfusainey - I do need to clean up the documentation side of it but if there's anything else that appears glaringly wrong pls let me know. @pierDipi - if you could start taking a peek at this I'd appreciate it. |
/** | ||
* Get the default content type to assume for MQTT messages. | ||
* @return A Content-Type | ||
*/ | ||
public static final String getDefaultContentType() { | ||
return DEFAULT_FORMAT; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's rationale for using a public static method vs referencing the field directly and make it public?
// No-Op | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we throw an exception in this case mostly for "internal safety"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I need to do some general clean-up ..
As an aside do we know why the definition of a 'MessageWriter' interface is so complicated, I'm not sure why it needs to extend other writers and factories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On multiple files the copyright header is missing:
sdk-java/api/src/main/java/io/cloudevents/lang/Nullable.java
Lines 1 to 16 in 4c81f3e
/* | |
* Copyright 2018-Present The CloudEvents Authors | |
* <p> | |
* Licensed under the Apache License, Version 2.0 (the "License"); | |
* you may not use this file except in compliance with the License. | |
* You may obtain a copy of the License at | |
* <p> | |
* http://www.apache.org/licenses/LICENSE-2.0 | |
* <p> | |
* Unless required by applicable law or agreed to in writing, software | |
* distributed under the License is distributed on an "AS IS" BASIS, | |
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
* See the License for the specific language governing permissions and | |
* limitations under the License. | |
* | |
*/ |
bindings/mqtt/core/src/main/java/io/cloudevents/mqtt/core/BaseMqttBinaryMessageReader.java
Show resolved
Hide resolved
bindings/mqtt/core/src/main/java/io/cloudevents/mqtt/core/MqttUtils.java
Outdated
Show resolved
Hide resolved
btw, I'm still going through it |
thx ... I'll try and take a look at this next week now that the proto changes are in ... |
Signed-off-by: Jem Day <[email protected]>
For comment at present - DO NOT MERGE.
Contains MQTT V3 & V5 binding implementations for the Paho and HiveMQ client libraries.
Closes #335