Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support up to microsecond precision input timestamps #37

Merged
merged 4 commits into from
Dec 15, 2021
Merged

Support up to microsecond precision input timestamps #37

merged 4 commits into from
Dec 15, 2021

Conversation

GrahamCampbell
Copy link
Contributor

The spec technically says there can be an arbitrary number of digits here, but I don't know of any OSS software that writes out more than 6 numbers, so this should be fine.


Closes #35.

Copy link
Contributor

@jlaswell jlaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We will probably want to update the workflow eventually to run against php 7.4 and 8 if we want to keep support there.

cc: @anniefu

@jlaswell jlaswell merged commit 602cd26 into cloudevents:master Dec 15, 2021
@GrahamCampbell GrahamCampbell deleted the microsecond-input branch December 15, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonDeserializer can't handle all RFC3339 timestamps
2 participants