-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Semaphore CI provider #1485
base: main
Are you sure you want to change the base?
Conversation
2270741
to
82e616e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1485 +/- ##
==========================================
- Coverage 92.78% 92.61% -0.17%
==========================================
Files 36 37 +1
Lines 1358 1395 +37
Branches 273 281 +8
==========================================
+ Hits 1260 1292 +32
- Misses 68 72 +4
- Partials 30 31 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @benregn! Just some changes. Do you also have a semaphore CI run to run this off of?
82e616e
to
14c7232
Compare
@thomasrockhu-codecov Thank you for the feedback! Overlooked that those lines weren't needed anymore 🤦 We're using Semaphore at my place of work. |
@thomasrockhu-codecov ping 🙂 |
Closes #1238 🙌