Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Music Stack Interaction widget #314

Merged
merged 13 commits into from
Oct 17, 2024

Conversation

mohitahlawat2001
Copy link
Contributor

#273

Screen.Recording.2024-10-04.224124.mp4

animata/widget/music-stack-interaction.tsx Outdated Show resolved Hide resolved
animata/widget/music-stack-interaction.tsx Outdated Show resolved Hide resolved
animata/widget/music-stack-interaction.tsx Outdated Show resolved Hide resolved
@hari
Copy link
Contributor

hari commented Oct 5, 2024

@mohitahlawat2001 Instead of fixing on animata/widget/music-stack-interaction.tsx you modified the animata/widget/music-stack-interaction.stories.tsx. Please move the logic to music-stack-interaction.tsx and update the story.

@mohitahlawat2001
Copy link
Contributor Author

doing in 10 minutes

@mohitahlawat2001
Copy link
Contributor Author

Screen.Recording.2024-10-05.212123.mp4

@hari
Copy link
Contributor

hari commented Oct 6, 2024

@mohitahlawat2001 The animation is glitchy, use can fix this by changing the style values instead of using the layout animation.

@mohitahlawat2001
Copy link
Contributor Author

i make some change and make animation smooth ,

Copy link

github-actions bot commented Oct 7, 2024

🚀 Preview deployed to: https://fdc3e761.animata.pages.dev

@hari
Copy link
Contributor

hari commented Oct 15, 2024

Please fix the build issue @mohitahlawat2001


./animata/widget/music-stack-interaction.stories.tsx:18:3
Type error: Type '{ albums: { id: number; title: string; artist: string; cover: string; }[]; }' is not assignable to type 'Partial<{ albums: { id: number; title: string; artist: string; cover: string; }[]; albumCover: string; }> & { albums: { id: number; title: string; artist: string; cover: string; }[]; albumCover: string; }'.
  Property 'albumCover' is missing in type '{ albums: { id: number; title: string; artist: string; cover: string; }[]; }' but required in type '{ albums: { id: number; title: string; artist: string; cover: string; }[]; albumCover: string; }'.

  16 |
  17 | export const Primary: Story = {
> 18 |   args: {
     |   ^
  19 |     albums: [
  20 |       {
  21 |         id: 1,

@mohitahlawat2001
Copy link
Contributor Author

i made change for solving error

Copy link

🚀 Preview deployed to: https://4142c50d.animata.pages.dev

@hari hari merged commit f74de40 into codse:main Oct 17, 2024
2 checks passed
@sudhashrestha sudhashrestha added the hacktoberfest This issue is a part of the Hacktoberfest event label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest This issue is a part of the Hacktoberfest event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants