-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(button): added ripple button, issue #300 #350
Conversation
Please fix the TS error, you will need to cast the element.
|
I fixed the casting issue, please check. |
🚀 Preview deployed to: https://f7f39c8b.animata.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AE-Hertz Please use tailwindcss.
@hari i am facing some issues and i am unable to figure out the reason - issue facing (after removing keyframes and animation from inline-css) - Screen.Recording.2024-10-08.232955.mp4If you can guide me on this , that would be great. Thank you |
@hari attaching a screenshot below, this much inlinecss is must to make this effect work, please let me know what can i do. |
@AE-Hertz could you push the lastest changes so I can run it locally? |
@hari yes i did, please check |
🚀 Preview deployed to: https://8e9bf933.animata.pages.dev |
@AE-Hertz There is a bug when moving the mouse quickly. The ripple gets stuck. Screen.Recording.2024-10-15.at.3.40.59.PM.mov |
@hari i tried to resolve and after researching i found its actually the issue with react onMouseLeave() , read many article like this - https://stackoverflow.com/questions/29981236/how-do-you-hover-in-reactjs-onmouseleave-not-registered-during-fast-hover-ove its an old issue but i did not able to find any solution. If their is something with your knowledge please share with me , i will implement it. |
@hari please check i think this method to handle mouse event by checking the state is more consistent. Screen.Recording.2024-10-17.125536.mp4If everything is fine, Please merge my PRs |
🚀 Preview deployed to: https://02756ac4.animata.pages.dev |
@AE-Hertz instead of state you can use ref to track the hovered state. |
yeah , actually. should i change it then? |
@AE-Hertz sure, why not? |
@hari hey i implemented it with useRef but its not as consistent as this version(useState), thats why not pushing that code(useRef) . see clip. Screen.Recording.2024-10-17.212747.mp4 |
@hari well, i used both useRef and useState for better consistency, sending PR . |
🚀 Preview deployed to: https://20a1cd8e.animata.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @AE-Hertz
I am attaching a working video-
Screen.Recording.2024-10-07.112547.mp4
Please review it as its my first project working with storybook, i dont want to break your application by any means.
I have also made this in react here is the github repo - https://github.com/AE-Hertz/Mouse-hover-effect
Closes #300