Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fluid-tabs): added fluid tabs component #351

Merged
merged 4 commits into from
Oct 15, 2024
Merged

feat(fluid-tabs): added fluid tabs component #351

merged 4 commits into from
Oct 15, 2024

Conversation

Rudra-Sankha-Sinhamahapatra
Copy link
Contributor

@Rudra-Sankha-Sinhamahapatra Rudra-Sankha-Sinhamahapatra commented Oct 7, 2024 •
edited by sudhashrestha
Loading

Created the fluid tabs component
Fixes #325

Hey @hari can you please review it

Screen.Recording.2024-10-07.062913.mp4

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

🚀 Preview deployed to: https://2f1f85d4.animata.pages.dev

@Rudra-Sankha-Sinhamahapatra
Copy link
Contributor Author

@hari can you please review this PR?

hari
hari requested changes Oct 8, 2024
View reviewed changes
animata/card/fluid-tabs.tsx Outdated Show resolved Hide resolved
animata/card/fluid-tabs.tsx Outdated Show resolved Hide resolved
animata/card/fluid-tabs.tsx Outdated Show resolved Hide resolved
@Rudra-Sankha-Sinhamahapatra
Copy link
Contributor Author

Rudra-Sankha-Sinhamahapatra commented Oct 8, 2024 •
edited
Loading

image
@hari done, can you please review it now

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

🚀 Preview deployed to: https://390f8b78.animata.pages.dev

hari
hari requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@hari hari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rudra-Sankha-Sinhamahapatra Maybe blurring the other items rather than the clicked one will look better? Please check and make the changes if it feels right.

animata/card/fluid-tabs.tsx Outdated Show resolved Hide resolved
animata/card/fluid-tabs.tsx Outdated Show resolved Hide resolved
@Rudra-Sankha-Sinhamahapatra
Copy link
Contributor Author

@hari sir i tried your suggestions but i think the current animation which was in the issue looks better, so i am currently not changing anything else ... but i have made those ui changes you mentioned..kindly check it please

@github-actions GitHub Actions
Copy link

🚀 Preview deployed to: https://85d4669f.animata.pages.dev

@github-actions GitHub Actions
Copy link

🚀 Preview deployed to: https://514f0a4e.animata.pages.dev

@Rudra-Sankha-Sinhamahapatra
Copy link
Contributor Author

@hari can you check now please

@hari hari merged commit 46ce9d9 into codse:main Oct 15, 2024
2 checks passed
@sudhashrestha sudhashrestha added the hacktoberfest This issue is a part of the Hacktoberfest event label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hari hari hari approved these changes

Assignees
No one assigned
Labels
hacktoberfest This issue is a part of the Hacktoberfest event
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fluid tabs
3 participants
@Rudra-Sankha-Sinhamahapatra @hari @sudhashrestha