Add a conformance test for MultipleInputFeatureRequirement on Workflow outputs #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
commented
May 10, 2022
| @@ -3532,3 +3532,15 @@ | |||
| doc: | | |||
| Use of $(runtime.outdir) for outputBinding glob. | |||
| tags: [ required, command_line_tool ] | |||
|
|
|||
| - label: multiple-input-feature-requirement | |||
There was a problem hiding this comment.
p.s.: was reading the doc for conformance tests, and noticed this line:
label: a short list of underscore (_) separated words that succinctly identifies and explains the test.
I had already used dashes, as I did in the previous test, where I followed the pattern of the previous test… Is there a reason for underscores? Should we fix the existing labels? Or maybe update https://github.com/common-workflow-language/cwl-v1.2/blob/1.2.1_proposed/CONFORMANCE_TESTS.md?
There was a problem hiding this comment.
Hmm.. I don't have a strong opinion right now, except that we should be consistent. Can you make a separate issue to discuss this?
70 tasks
mr-c
approved these changes
Jun 21, 2022
kinow
force-pushed
the
multiple_input-output
branch
from
1d69046
to
e64d342
Compare
|
Rebased and fixed conflicts. |
kinow
added a commit
to kinow/cwl-v1.2
that referenced
this pull request
Oct 20, 2022
GlassOfWhiskey
pushed a commit
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For common-workflow-language/common-workflow-language#637
Tried to write a test that calls
echo-tool.cwltwice, storing the output, and then uses both values in the workflow outputs. Confirmed it fails without theMultipleInputFeatureRequirement.