Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

napari 0.4.15 and vispy 0.10 are incompatible #40

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

jni
Copy link
Contributor

@jni jni commented Apr 26, 2022

This prevents 0.4.15 and vispy 0.10 from being installed together by default.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jni jni merged commit 42461d1 into conda-forge:main Apr 26, 2022
@jni jni deleted the vispy-0.10 branch April 26, 2022 10:13
@jaimergp
Copy link
Member

The solver might still choose the old build (number 0) without the upper bound, so we might want to also add a repodata patch!

@jni
Copy link
Contributor Author

jni commented Apr 27, 2022

@jaimergp can you elaborate? I don't really know what that means! But you are absolutely right, conda create -n napari-conda -c conda-forge python=3.10 napari=0.4.15 installs vispy=0.10 😞

@goanpeca
Copy link
Member

I guess something similar to what I was doing here @jni

conda-forge/conda-forge-repodata-patches-feedstock#231

@jni
Copy link
Contributor Author

jni commented Apr 29, 2022

@goanpeca you have just shattered my world-view of a completely declarative conda-forge ecosystem... 😂

@jaimergp
Copy link
Member

In this case, I think we will mark the build 0 as broken instead, since this new build effectively replaces the previous one. For future occasions, a repodata patch would suffice without needing a rebuild. It's not as critical for noarch packages like this one but it can involve significant resources in compiled packages.

@jni
Copy link
Contributor Author

jni commented May 2, 2022

Thank you both and apologies for the rushed and incorrect fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants