Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PartSeg recipe #17861

Merged
merged 8 commits into from
Apr 1, 2022
Merged

Add PartSeg recipe #17861

merged 8 commits into from
Apr 1, 2022

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Feb 1, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter

This comment was marked as outdated.

@goanpeca
Copy link
Member Author

goanpeca commented Feb 1, 2022

We are in the process of creating conda packages for napari plugins and related dependencies. Once this recipe passes all the checks, every time a new release goes into PyPI, a PR will be automatically open, with usually very minor need for changes so the process of maintaining this moving forward is small. Also the @conda-forge/napari team will be available to help as needed.

You can read a bit more about conda-forge at https://conda-forge.org/#contribute


@Czaki, do you agree with being added as a maintainer?

@goanpeca
Copy link
Member Author

goanpeca commented Feb 1, 2022

@Czaki
Copy link
Contributor

Czaki commented Feb 1, 2022

@Czaki, do you agree with being added as a maintainer?

yes

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/PartSeg) and found it was in an excellent condition.

@goanpeca
Copy link
Member Author

@conda-forge-linter

This comment was marked as outdated.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/PartSeg) and found it was in an excellent condition.

@jaimergp
Copy link
Member

Depends on:

Merged!

@goanpeca goanpeca closed this Feb 23, 2022
@goanpeca goanpeca reopened this Feb 23, 2022
@goanpeca
Copy link
Member Author

@Czaki
Copy link
Contributor

Czaki commented Feb 25, 2022

@goanpeca As napari just drop python 3.7 support, then PartSeg will drop support for python 3.7 in a short time. So if support of python 3.7 requires an additional job then this python version could be omitted.

recipes/PartSeg/meta.yaml Outdated Show resolved Hide resolved
recipes/PartSeg/meta.yaml Outdated Show resolved Hide resolved
skip: true # [py<38]
entry_points:
- PartSeg = PartSeg.launcher_main:main
- Tester = PartSeg.test_widget_main:main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Tester = PartSeg.test_widget_main:main
- PartSeg-Tester = PartSeg.test_widget_main:main

@Czaki - is it ok if we rename this script? Tester is a bit too generic and I am concerned it might clash other tools in either conda-forge or the broader ecosystem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete it. I will also do this in PartSeg

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Grzegorz Bokota <[email protected]>
@jaimergp jaimergp marked this pull request as ready for review April 1, 2022 11:11
@jaimergp jaimergp merged commit 713dbea into conda-forge:main Apr 1, 2022
@goanpeca goanpeca deleted the add-partseg branch April 12, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants