-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: changed destination of ai lab port settings #2052
base: main
Are you sure you want to change the base?
chore: changed destination of ai lab port settings #2052
Conversation
TODO: add unit test |
question: it's not clear to me in the issue if it means that the configuration should be removed from the classic configuration page of any extension. |
side comment: also it's possible to provide a markdown description in the properties. So it looks like we're trying to reinvent the wheel of how each extension will be configured |
cc @slemeur |
packages/backend/package.json
Outdated
@@ -44,13 +44,6 @@ | |||
"default": false, | |||
"description": "Experimental GPU support for inference servers" | |||
}, | |||
"ai-lab.apiPort": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be removed
@benoitf: The intent was to expose the REST Server capabilities from Podman AI Lab, by providing its own page. Right now, it would only explain what it does and provides the ability to configure the server port. In the future the user could in the future:
Does that make sense to you? Considering your feedback, I agree that the "Configurable Options" is going to be confusing. Maybe, we should call the section: "Local Server" and the subpage "Server Information", wdyt? |
@slemeur my point was that any configuration should stay at a minimum in the "generic configuration" settings (what is being exposed by an extension) then the extension can still decide to expose it through a different UI, but being "on top of the configuration settings" so, more keep it at both place (if I go to all settings and filter for AI Lab extension, I should be able to find something there) |
Ok that makes sense indeed. |
@gastoner: I've updated the initial issue. Here are the changes for your PR:
|
fc113fb
to
2dadc21
Compare
Signed-off-by: Evzen Gasta <[email protected]>
Signed-off-by: Evzen Gasta <[email protected]>
Signed-off-by: Evzen Gasta <[email protected]>
8a5df4a
to
085e635
Compare
Signed-off-by: Evzen Gasta <[email protected]>
What does this PR do?
Changes destination of ai lab port settings
Screenshot / video of UI
What issues does this PR fix or reference?
Closes #1978
How to test this PR?
Go to AI Lab, there should be a new navigation item with the settings