Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix types & docs for upload credentials [] #2466

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

2wce
Copy link
Contributor

@2wce 2wce commented Nov 14, 2024

Summary

we were not exporting the types for the new upload credentials method. Our example for how to use the method was also out of date. This should be fixed now

Checklist (check all before merging)

  • Both unit and integration tests are passing
  • There are no breaking changes
  • Changes are reflected in the documentation

When adding a new method:

  • The new method is exported through the default and plain CMA client
  • All new public types are exported from ./lib/export-types.ts
  • Added a unit test for the new method
  • Added an integration test for the new method
  • The new method is added to the documentation

@2wce 2wce requested a review from a team as a code owner November 14, 2024 07:57
@2wce 2wce self-assigned this Nov 14, 2024
@2wce 2wce merged commit 25c15f5 into master Nov 14, 2024
3 checks passed
@2wce 2wce deleted the chore/fix-upload-credentials-types-and-docs branch November 14, 2024 09:21
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 11.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants